Discussion:
[gem5-dev] Change in gem5/gem5[master]: systemc: Run the systemc tests with the CWD in the build directory.
(too old to reply)
Gabe Black (Gerrit)
2018-11-22 02:00:35 UTC
Permalink
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14518


Change subject: systemc: Run the systemc tests with the CWD in the build
directory.
......................................................................

systemc: Run the systemc tests with the CWD in the build directory.

This will prevent some (but not all) output files the tests generate
from ending up outside the build directory. Because some output file
streams are constructed as global objects, their paths are resolved
relative to the CWD when gem5 starts, before the config script has a
chance to change it.

Subsequent changes will make verify.py should make gem5 start with the
correct working directory, cleaning up the remaining leaking files.

Change-Id: I75a1256719dab4c98ab868c209d09b9dcdabb458
---
M src/systemc/tests/verify.py
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/systemc/tests/verify.py b/src/systemc/tests/verify.py
index 87c5d12..c9ede77 100755
--- a/src/systemc/tests/verify.py
+++ b/src/systemc/tests/verify.py
@@ -165,7 +165,7 @@
'--quiet',
config_path,
'--working-dir',
- os.path.dirname(test.src_dir())
+ os.path.dirname(test.dir())
])
# Ensure the output directory exists.
if not os.path.exists(test.m5out_dir()):
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14518
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I75a1256719dab4c98ab868c209d09b9dcdabb458
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-MessageType: newchange
Gabe Black (Gerrit)
2018-11-29 01:22:15 UTC
Permalink
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14518 )

Change subject: systemc: Run the systemc tests with the CWD in the build
directory.
......................................................................

systemc: Run the systemc tests with the CWD in the build directory.

This will prevent some (but not all) output files the tests generate
from ending up outside the build directory. Because some output file
streams are constructed as global objects, their paths are resolved
relative to the CWD when gem5 starts, before the config script has a
chance to change it.

Subsequent changes will make verify.py should make gem5 start with the
correct working directory, cleaning up the remaining leaking files.

Change-Id: I75a1256719dab4c98ab868c209d09b9dcdabb458
Reviewed-on: https://gem5-review.googlesource.com/c/14518
Reviewed-by: Gabe Black <***@google.com>
Maintainer: Gabe Black <***@google.com>
---
M src/systemc/tests/verify.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved



diff --git a/src/systemc/tests/verify.py b/src/systemc/tests/verify.py
index 87c5d12..c9ede77 100755
--- a/src/systemc/tests/verify.py
+++ b/src/systemc/tests/verify.py
@@ -165,7 +165,7 @@
'--quiet',
config_path,
'--working-dir',
- os.path.dirname(test.src_dir())
+ os.path.dirname(test.dir())
])
# Ensure the output directory exists.
if not os.path.exists(test.m5out_dir()):
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14518
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I75a1256719dab4c98ab868c209d09b9dcdabb458
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-Reviewer: Matthias Jung <***@eit.uni-kl.de>
Gerrit-MessageType: merged
Continue reading on narkive:
Loading...