Discussion:
[gem5-dev] Change in gem5/gem5[master]: systemc: Make a test use cout for all its messages.
(too old to reply)
Gabe Black (Gerrit)
2018-08-22 02:13:25 UTC
Permalink
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/12216


Change subject: systemc: Make a test use cout for all its messages.
......................................................................

systemc: Make a test use cout for all its messages.

This makes them end up in simout so verify.py can find them when it's
checking output.

Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
---
M src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git
a/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
b/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
index 7b2502d..d1b345e 100644
--- a/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
+++ b/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
@@ -111,7 +111,7 @@
ACTION(sc_start(0, SC_NS),"sc_start(0, SC_NS)")
ACTION(sc_start(0, SC_NS),"sc_start(0, SC_NS)")

- cerr << "Program completed" << endl;
+ cout << "Program completed" << endl;
return 0;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12216
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
Gerrit-Change-Number: 12216
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-MessageType: newchange
Gabe Black (Gerrit)
2018-08-22 02:19:37 UTC
Permalink
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/12216

to look at the new patch set (#2).

Change subject: systemc: Make a test use cout for all its messages.
......................................................................

systemc: Make a test use cout for all its messages.

This makes them end up in simout so verify.py can find them when it's
checking output.

Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
---
M src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12216
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
Gerrit-Change-Number: 12216
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-Reviewer: Matthias Jung <***@eit.uni-kl.de>
Gerrit-MessageType: newpatchset
Gabe Black (Gerrit)
2018-08-28 21:45:21 UTC
Permalink
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/12216

to look at the new patch set (#4).

Change subject: systemc: Make a test use cout for all its messages.
......................................................................

systemc: Make a test use cout for all its messages.

This makes them end up in simout so verify.py can find them when it's
checking output.

Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
---
M src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12216
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
Gerrit-Change-Number: 12216
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-Reviewer: Matthias Jung <***@eit.uni-kl.de>
Gerrit-MessageType: newpatchset
Gabe Black (Gerrit)
2018-09-05 06:14:30 UTC
Permalink
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/12216

to look at the new patch set (#6).

Change subject: systemc: Make a test use cout for all its messages.
......................................................................

systemc: Make a test use cout for all its messages.

This makes them end up in simout so verify.py can find them when it's
checking output.

Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
---
M src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12216
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
Gerrit-Change-Number: 12216
Gerrit-PatchSet: 6
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-Reviewer: Matthias Jung <***@eit.uni-kl.de>
Gerrit-MessageType: newpatchset
Gabe Black (Gerrit)
2018-09-20 11:23:24 UTC
Permalink
Hello Jason Lowe-Power, Matthias Jung, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/12216

to look at the new patch set (#9).

Change subject: systemc: Make a test use cout for all its messages.
......................................................................

systemc: Make a test use cout for all its messages.

This makes them end up in simout so verify.py can find them when it's
checking output.

Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
---
M src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12216
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
Gerrit-Change-Number: 12216
Gerrit-PatchSet: 9
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-Reviewer: Matthias Jung <***@eit.uni-kl.de>
Gerrit-MessageType: newpatchset
Gabe Black (Gerrit)
2018-09-25 23:50:44 UTC
Permalink
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/12216 )

Change subject: systemc: Make a test use cout for all its messages.
......................................................................

systemc: Make a test use cout for all its messages.

This makes them end up in simout so verify.py can find them when it's
checking output.

Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
Reviewed-on: https://gem5-review.googlesource.com/12216
Reviewed-by: Gabe Black <***@google.com>
Maintainer: Gabe Black <***@google.com>
---
M src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved



diff --git
a/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
b/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
index 7b2502d..d1b345e 100644
--- a/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
+++ b/src/systemc/tests/systemc/kernel/sc_start/sc_start_0/test1/test1.cpp
@@ -111,7 +111,7 @@
ACTION(sc_start(0, SC_NS),"sc_start(0, SC_NS)")
ACTION(sc_start(0, SC_NS),"sc_start(0, SC_NS)")

- cerr << "Program completed" << endl;
+ cout << "Program completed" << endl;
return 0;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12216
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I2b7b276b3e1816a257f58b0cfb13487d6296e6fd
Gerrit-Change-Number: 12216
Gerrit-PatchSet: 10
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-Reviewer: Matthias Jung <***@eit.uni-kl.de>
Gerrit-MessageType: merged
Continue reading on narkive:
Loading...