Discussion:
[gem5-dev] GCC4.X support
Giacomo Travaglini
2018-11-26 17:33:47 UTC
Permalink
Hi all,


There is an ongoing discussion about dropping support for gcc < 5.0.
(At the moment we support gcc/4.8: http://www.gem5.org/Dependencies<http://www.gem5.org/Dependencies)>)

It sparked from the following patch

https://gem5-review.googlesource.com/c/public/gem5/+/14315

which is keeping gem5 gcc4.x compliant. If we decide to drop support, I will abandon the patch.
(ideally when http://www.gem5.org/Dependencies gets updated)

Does anybody have any concern about that?

Thanks

Giacomo


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Jason Lowe-Power
2018-11-26 18:53:56 UTC
Permalink
Dropping 4.8/4.9 works for me. Maybe we should also email gem5-users to see
if anyone is using old clusters.

Jason

On Mon, Nov 26, 2018 at 9:34 AM Giacomo Travaglini <
***@arm.com> wrote:

> Hi all,
>
>
> There is an ongoing discussion about dropping support for gcc < 5.0.
> (At the moment we support gcc/4.8: http://www.gem5.org/Dependencies<
> http://www.gem5.org/Dependencies)>)
>
> It sparked from the following patch
>
> https://gem5-review.googlesource.com/c/public/gem5/+/14315
>
> which is keeping gem5 gcc4.x compliant. If we decide to drop support, I
> will abandon the patch.
> (ideally when http://www.gem5.org/Dependencies gets updated)
>
> Does anybody have any concern about that?
>
> Thanks
>
> Giacomo
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
> _______________________________________________
> gem5-dev mailing list
> gem5-***@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
Chang Hyun Park
2018-11-27 02:11:34 UTC
Permalink
Dear Jason and Giacomo,

We are running our simulation clusters on Ubuntu 14.04 (LTS) which will expire next April.
Ubuntu 14.04 ships with GCC 4.8.

If its not too much hassle supporting 4.8, what about dropping support for gcc < 5.0 after the EOL of Ubuntu 14.04?
(So perhaps drop support for gcc < 5.0 beginning May 2019)

Best Regards,
Chang Hyun Park

> On 27 Nov 2018, at 3:53 AM, Jason Lowe-Power <***@lowepower.com> wrote:
>
> Dropping 4.8/4.9 works for me. Maybe we should also email gem5-users to see
> if anyone is using old clusters.
>
> Jason
>
> On Mon, Nov 26, 2018 at 9:34 AM Giacomo Travaglini <
> ***@arm.com> wrote:
>
>> Hi all,
>>
>>
>> There is an ongoing discussion about dropping support for gcc < 5.0.
>> (At the moment we support gcc/4.8: http://www.gem5.org/Dependencies<
>> http://www.gem5.org/Dependencies)>)
>>
>> It sparked from the following patch
>>
>> https://gem5-review.googlesource.com/c/public/gem5/+/14315
>>
>> which is keeping gem5 gcc4.x compliant. If we decide to drop support, I
>> will abandon the patch.
>> (ideally when http://www.gem5.org/Dependencies gets updated)
>>
>> Does anybody have any concern about that?
>>
>> Thanks
>>
>> Giacomo
>>
>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are
>> confidential and may also be privileged. If you are not the intended
>> recipient, please notify the sender immediately and do not disclose the
>> contents to any other person, use it for any purpose, or store or copy the
>> information in any medium. Thank you.
>> _______________________________________________
>> gem5-dev mailing list
>> gem5-***@gem5.org
>> http://m5sim.org/mailman/listinfo/gem5-dev
> _______________________________________________
> gem5-dev mailing list
> gem5-***@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
Giacomo Travaglini
2018-11-29 13:19:32 UTC
Permalink
Hi Chang,


I think it makes sense to wait until EOL of Ubuntu 14.04.

We should consider about fixing the bug then, or to explicitly say in gem5.org that SYSTEMC has to be disabled in order

to be compliant (which is not the best approach IMO).


Gabe, what's your opinion on this? Can you provide a better alternative to my patch?

Otherwise, If nobody wants to spend time on this I feel we should go on merging the patch with a remainder of reverting it

once we deprecate usage of GCC4.8/9


Giacomo

________________________________
From: gem5-dev <gem5-dev-***@gem5.org> on behalf of Chang Hyun Park <***@gmail.com>
Sent: 27 November 2018 02:11:34
To: gem5 Developer List
Subject: Re: [gem5-dev] GCC4.X support

Dear Jason and Giacomo,

We are running our simulation clusters on Ubuntu 14.04 (LTS) which will expire next April.
Ubuntu 14.04 ships with GCC 4.8.

If its not too much hassle supporting 4.8, what about dropping support for gcc < 5.0 after the EOL of Ubuntu 14.04?
(So perhaps drop support for gcc < 5.0 beginning May 2019)

Best Regards,
Chang Hyun Park

> On 27 Nov 2018, at 3:53 AM, Jason Lowe-Power <***@lowepower.com> wrote:
>
> Dropping 4.8/4.9 works for me. Maybe we should also email gem5-users to see
> if anyone is using old clusters.
>
> Jason
>
> On Mon, Nov 26, 2018 at 9:34 AM Giacomo Travaglini <
> ***@arm.com> wrote:
>
>> Hi all,
>>
>>
>> There is an ongoing discussion about dropping support for gcc < 5.0.
>> (At the moment we support gcc/4.8: http://www.gem5.org/Dependencies<
>> http://www.gem5.org/Dependencies)>)
>>
>> It sparked from the following patch
>>
>> https://gem5-review.googlesource.com/c/public/gem5/+/14315
>>
>> which is keeping gem5 gcc4.x compliant. If we decide to drop support, I
>> will abandon the patch.
>> (ideally when http://www.gem5.org/Dependencies gets updated)
>>
>> Does anybody have any concern about that?
>>
>> Thanks
>>
>> Giacomo
>>
>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are
>> confidential and may also be privileged. If you are not the intended
>> recipient, please notify the sender immediately and do not disclose the
>> contents to any other person, use it for any purpose, or store or copy the
>> information in any medium. Thank you.
>> _______________________________________________
>> gem5-dev mailing list
>> gem5-***@gem5.org
>> http://m5sim.org/mailman/listinfo/gem5-dev
> _______________________________________________
> gem5-dev mailing list
> gem5-***@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev

_______________________________________________
gem5-dev mailing list
gem5-***@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Jason Lowe-Power
2018-11-29 16:52:08 UTC
Permalink
This post might be inappropriate. Click to display it.
Gabe Black
2018-11-30 00:05:44 UTC
Permalink
I commented on the CL if we decide to check it in. I'm not 100% sure what's
best, but the more I think about it the more I tend to agree with Jason.
That would probably be the least invasive thing to do, given its temporary
nature. It would be a bit awkward and clunky for anybody that hits it, but
hopefully that set is very small or empty.

Gabe

On Thu, Nov 29, 2018 at 8:52 AM Jason Lowe-Power <***@lowepower.com>
wrote:

> I advocate for explicitly stating that SystemC should be disabled for gcc <
> 5.0 and making this change in the SConscript with a warning. I don't think
> the SystemC support is widely used right now, and few people are stuck on
> 4.8, so I doubt it will affect anyone. We can even include a link to the
> gerrit patch that fixes it in the SCons warning.
>
> Jason
>
> On Thu, Nov 29, 2018 at 5:19 AM Giacomo Travaglini <
> ***@arm.com> wrote:
>
> > Hi Chang,
> >
> >
> > I think it makes sense to wait until EOL of Ubuntu 14.04.
> >
> > We should consider about fixing the bug then, or to explicitly say in
> > gem5.org that SYSTEMC has to be disabled in order
> >
> > to be compliant (which is not the best approach IMO).
> >
> >
> > Gabe, what's your opinion on this? Can you provide a better alternative
> to
> > my patch?
> >
> > Otherwise, If nobody wants to spend time on this I feel we should go on
> > merging the patch with a remainder of reverting it
> >
> > once we deprecate usage of GCC4.8/9
> >
> >
> > Giacomo
> >
> > ________________________________
> > From: gem5-dev <gem5-dev-***@gem5.org> on behalf of Chang Hyun Park
> <
> > ***@gmail.com>
> > Sent: 27 November 2018 02:11:34
> > To: gem5 Developer List
> > Subject: Re: [gem5-dev] GCC4.X support
> >
> > Dear Jason and Giacomo,
> >
> > We are running our simulation clusters on Ubuntu 14.04 (LTS) which will
> > expire next April.
> > Ubuntu 14.04 ships with GCC 4.8.
> >
> > If its not too much hassle supporting 4.8, what about dropping support
> for
> > gcc < 5.0 after the EOL of Ubuntu 14.04?
> > (So perhaps drop support for gcc < 5.0 beginning May 2019)
> >
> > Best Regards,
> > Chang Hyun Park
> >
> > > On 27 Nov 2018, at 3:53 AM, Jason Lowe-Power <***@lowepower.com>
> > wrote:
> > >
> > > Dropping 4.8/4.9 works for me. Maybe we should also email gem5-users to
> > see
> > > if anyone is using old clusters.
> > >
> > > Jason
> > >
> > > On Mon, Nov 26, 2018 at 9:34 AM Giacomo Travaglini <
> > > ***@arm.com> wrote:
> > >
> > >> Hi all,
> > >>
> > >>
> > >> There is an ongoing discussion about dropping support for gcc < 5.0.
> > >> (At the moment we support gcc/4.8: http://www.gem5.org/Dependencies<
> > >> http://www.gem5.org/Dependencies)>)
> > >>
> > >> It sparked from the following patch
> > >>
> > >> https://gem5-review.googlesource.com/c/public/gem5/+/14315
> > >>
> > >> which is keeping gem5 gcc4.x compliant. If we decide to drop support,
> I
> > >> will abandon the patch.
> > >> (ideally when http://www.gem5.org/Dependencies gets updated)
> > >>
> > >> Does anybody have any concern about that?
> > >>
> > >> Thanks
> > >>
> > >> Giacomo
> > >>
> > >>
> > >> IMPORTANT NOTICE: The contents of this email and any attachments are
> > >> confidential and may also be privileged. If you are not the intended
> > >> recipient, please notify the sender immediately and do not disclose
> the
> > >> contents to any other person, use it for any purpose, or store or copy
> > the
> > >> information in any medium. Thank you.
> > >> _______________________________________________
> > >> gem5-dev mailing list
> > >> gem5-***@gem5.org
> > >> http://m5sim.org/mailman/listinfo/gem5-dev
> > > _______________________________________________
> > > gem5-dev mailing list
> > > gem5-***@gem5.org
> > > http://m5sim.org/mailman/listinfo/gem5-dev
> >
> > _______________________________________________
> > gem5-dev mailing list
> > gem5-***@gem5.org
> > http://m5sim.org/mailman/listinfo/gem5-dev
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended
> > recipient, please notify the sender immediately and do not disclose the
> > contents to any other person, use it for any purpose, or store or copy
> the
> > information in any medium. Thank you.
> > _______________________________________________
> > gem5-dev mailing list
> > gem5-***@gem5.org
> > http://m5sim.org/mailman/listinfo/gem5-dev
> _______________________________________________
> gem5-dev mailing list
> gem5-***@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
Jason Lowe-Power
2018-11-30 01:08:31 UTC
Permalink
Gabe, can you put a patch together real fast that disables SystemC for gcc
< 5?

If not, I should be able to do it tomorrow.

Jason

On Thu, Nov 29, 2018 at 4:06 PM Gabe Black <***@google.com> wrote:

> I commented on the CL if we decide to check it in. I'm not 100% sure what's
> best, but the more I think about it the more I tend to agree with Jason.
> That would probably be the least invasive thing to do, given its temporary
> nature. It would be a bit awkward and clunky for anybody that hits it, but
> hopefully that set is very small or empty.
>
> Gabe
>
> On Thu, Nov 29, 2018 at 8:52 AM Jason Lowe-Power <***@lowepower.com>
> wrote:
>
> > I advocate for explicitly stating that SystemC should be disabled for
> gcc <
> > 5.0 and making this change in the SConscript with a warning. I don't
> think
> > the SystemC support is widely used right now, and few people are stuck on
> > 4.8, so I doubt it will affect anyone. We can even include a link to the
> > gerrit patch that fixes it in the SCons warning.
> >
> > Jason
> >
> > On Thu, Nov 29, 2018 at 5:19 AM Giacomo Travaglini <
> > ***@arm.com> wrote:
> >
> > > Hi Chang,
> > >
> > >
> > > I think it makes sense to wait until EOL of Ubuntu 14.04.
> > >
> > > We should consider about fixing the bug then, or to explicitly say in
> > > gem5.org that SYSTEMC has to be disabled in order
> > >
> > > to be compliant (which is not the best approach IMO).
> > >
> > >
> > > Gabe, what's your opinion on this? Can you provide a better alternative
> > to
> > > my patch?
> > >
> > > Otherwise, If nobody wants to spend time on this I feel we should go on
> > > merging the patch with a remainder of reverting it
> > >
> > > once we deprecate usage of GCC4.8/9
> > >
> > >
> > > Giacomo
> > >
> > > ________________________________
> > > From: gem5-dev <gem5-dev-***@gem5.org> on behalf of Chang Hyun
> Park
> > <
> > > ***@gmail.com>
> > > Sent: 27 November 2018 02:11:34
> > > To: gem5 Developer List
> > > Subject: Re: [gem5-dev] GCC4.X support
> > >
> > > Dear Jason and Giacomo,
> > >
> > > We are running our simulation clusters on Ubuntu 14.04 (LTS) which will
> > > expire next April.
> > > Ubuntu 14.04 ships with GCC 4.8.
> > >
> > > If its not too much hassle supporting 4.8, what about dropping support
> > for
> > > gcc < 5.0 after the EOL of Ubuntu 14.04?
> > > (So perhaps drop support for gcc < 5.0 beginning May 2019)
> > >
> > > Best Regards,
> > > Chang Hyun Park
> > >
> > > > On 27 Nov 2018, at 3:53 AM, Jason Lowe-Power <***@lowepower.com>
> > > wrote:
> > > >
> > > > Dropping 4.8/4.9 works for me. Maybe we should also email gem5-users
> to
> > > see
> > > > if anyone is using old clusters.
> > > >
> > > > Jason
> > > >
> > > > On Mon, Nov 26, 2018 at 9:34 AM Giacomo Travaglini <
> > > > ***@arm.com> wrote:
> > > >
> > > >> Hi all,
> > > >>
> > > >>
> > > >> There is an ongoing discussion about dropping support for gcc < 5.0.
> > > >> (At the moment we support gcc/4.8: http://www.gem5.org/Dependencies
> <
> > > >> http://www.gem5.org/Dependencies)>)
> > > >>
> > > >> It sparked from the following patch
> > > >>
> > > >> https://gem5-review.googlesource.com/c/public/gem5/+/14315
> > > >>
> > > >> which is keeping gem5 gcc4.x compliant. If we decide to drop
> support,
> > I
> > > >> will abandon the patch.
> > > >> (ideally when http://www.gem5.org/Dependencies gets updated)
> > > >>
> > > >> Does anybody have any concern about that?
> > > >>
> > > >> Thanks
> > > >>
> > > >> Giacomo
> > > >>
> > > >>
> > > >> IMPORTANT NOTICE: The contents of this email and any attachments are
> > > >> confidential and may also be privileged. If you are not the intended
> > > >> recipient, please notify the sender immediately and do not disclose
> > the
> > > >> contents to any other person, use it for any purpose, or store or
> copy
> > > the
> > > >> information in any medium. Thank you.
> > > >> _______________________________________________
> > > >> gem5-dev mailing list
> > > >> gem5-***@gem5.org
> > > >> http://m5sim.org/mailman/listinfo/gem5-dev
> > > > _______________________________________________
> > > > gem5-dev mailing list
> > > > gem5-***@gem5.org
> > > > http://m5sim.org/mailman/listinfo/gem5-dev
> > >
> > > _______________________________________________
> > > gem5-dev mailing list
> > > gem5-***@gem5.org
> > > http://m5sim.org/mailman/listinfo/gem5-dev
> > > IMPORTANT NOTICE: The contents of this email and any attachments are
> > > confidential and may also be privileged. If you are not the intended
> > > recipient, please notify the sender immediately and do not disclose the
> > > contents to any other person, use it for any purpose, or store or copy
> > the
> > > information in any medium. Thank you.
> > > _______________________________________________
> > > gem5-dev mailing list
> > > gem5-***@gem5.org
> > > http://m5sim.org/mailman/listinfo/gem5-dev
> > _______________________________________________
> > gem5-dev mailing list
> > gem5-***@gem5.org
> > http://m5sim.org/mailman/listinfo/gem5-dev
> _______________________________________________
> gem5-dev mailing list
> gem5-***@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
Gabe Black
2018-11-30 01:27:01 UTC
Permalink
Yes, although I don't have a version of gcc old enough to really test it
thoroughly. I might try to fake it by setting the cutoff really high for
testing purposes.

Gabe

On Thu, Nov 29, 2018 at 5:09 PM Jason Lowe-Power <***@lowepower.com>
wrote:

> Gabe, can you put a patch together real fast that disables SystemC for gcc
> < 5?
>
> If not, I should be able to do it tomorrow.
>
> Jason
>
> On Thu, Nov 29, 2018 at 4:06 PM Gabe Black <***@google.com> wrote:
>
> > I commented on the CL if we decide to check it in. I'm not 100% sure
> what's
> > best, but the more I think about it the more I tend to agree with Jason.
> > That would probably be the least invasive thing to do, given its
> temporary
> > nature. It would be a bit awkward and clunky for anybody that hits it,
> but
> > hopefully that set is very small or empty.
> >
> > Gabe
> >
> > On Thu, Nov 29, 2018 at 8:52 AM Jason Lowe-Power <***@lowepower.com>
> > wrote:
> >
> > > I advocate for explicitly stating that SystemC should be disabled for
> > gcc <
> > > 5.0 and making this change in the SConscript with a warning. I don't
> > think
> > > the SystemC support is widely used right now, and few people are stuck
> on
> > > 4.8, so I doubt it will affect anyone. We can even include a link to
> the
> > > gerrit patch that fixes it in the SCons warning.
> > >
> > > Jason
> > >
> > > On Thu, Nov 29, 2018 at 5:19 AM Giacomo Travaglini <
> > > ***@arm.com> wrote:
> > >
> > > > Hi Chang,
> > > >
> > > >
> > > > I think it makes sense to wait until EOL of Ubuntu 14.04.
> > > >
> > > > We should consider about fixing the bug then, or to explicitly say in
> > > > gem5.org that SYSTEMC has to be disabled in order
> > > >
> > > > to be compliant (which is not the best approach IMO).
> > > >
> > > >
> > > > Gabe, what's your opinion on this? Can you provide a better
> alternative
> > > to
> > > > my patch?
> > > >
> > > > Otherwise, If nobody wants to spend time on this I feel we should go
> on
> > > > merging the patch with a remainder of reverting it
> > > >
> > > > once we deprecate usage of GCC4.8/9
> > > >
> > > >
> > > > Giacomo
> > > >
> > > > ________________________________
> > > > From: gem5-dev <gem5-dev-***@gem5.org> on behalf of Chang Hyun
> > Park
> > > <
> > > > ***@gmail.com>
> > > > Sent: 27 November 2018 02:11:34
> > > > To: gem5 Developer List
> > > > Subject: Re: [gem5-dev] GCC4.X support
> > > >
> > > > Dear Jason and Giacomo,
> > > >
> > > > We are running our simulation clusters on Ubuntu 14.04 (LTS) which
> will
> > > > expire next April.
> > > > Ubuntu 14.04 ships with GCC 4.8.
> > > >
> > > > If its not too much hassle supporting 4.8, what about dropping
> support
> > > for
> > > > gcc < 5.0 after the EOL of Ubuntu 14.04?
> > > > (So perhaps drop support for gcc < 5.0 beginning May 2019)
> > > >
> > > > Best Regards,
> > > > Chang Hyun Park
> > > >
> > > > > On 27 Nov 2018, at 3:53 AM, Jason Lowe-Power <***@lowepower.com>
> > > > wrote:
> > > > >
> > > > > Dropping 4.8/4.9 works for me. Maybe we should also email
> gem5-users
> > to
> > > > see
> > > > > if anyone is using old clusters.
> > > > >
> > > > > Jason
> > > > >
> > > > > On Mon, Nov 26, 2018 at 9:34 AM Giacomo Travaglini <
> > > > > ***@arm.com> wrote:
> > > > >
> > > > >> Hi all,
> > > > >>
> > > > >>
> > > > >> There is an ongoing discussion about dropping support for gcc <
> 5.0.
> > > > >> (At the moment we support gcc/4.8:
> http://www.gem5.org/Dependencies
> > <
> > > > >> http://www.gem5.org/Dependencies)>)
> > > > >>
> > > > >> It sparked from the following patch
> > > > >>
> > > > >> https://gem5-review.googlesource.com/c/public/gem5/+/14315
> > > > >>
> > > > >> which is keeping gem5 gcc4.x compliant. If we decide to drop
> > support,
> > > I
> > > > >> will abandon the patch.
> > > > >> (ideally when http://www.gem5.org/Dependencies gets updated)
> > > > >>
> > > > >> Does anybody have any concern about that?
> > > > >>
> > > > >> Thanks
> > > > >>
> > > > >> Giacomo
> > > > >>
> > > > >>
> > > > >> IMPORTANT NOTICE: The contents of this email and any attachments
> are
> > > > >> confidential and may also be privileged. If you are not the
> intended
> > > > >> recipient, please notify the sender immediately and do not
> disclose
> > > the
> > > > >> contents to any other person, use it for any purpose, or store or
> > copy
> > > > the
> > > > >> information in any medium. Thank you.
> > > > >> _______________________________________________
> > > > >> gem5-dev mailing list
> > > > >> gem5-***@gem5.org
> > > > >> http://m5sim.org/mailman/listinfo/gem5-dev
> > > > > _______________________________________________
> > > > > gem5-dev mailing list
> > > > > gem5-***@gem5.org
> > > > > http://m5sim.org/mailman/listinfo/gem5-dev
> > > >
> > > > _______________________________________________
> > > > gem5-dev mailing list
> > > > gem5-***@gem5.org
> > > > http://m5sim.org/mailman/listinfo/gem5-dev
> > > > IMPORTANT NOTICE: The contents of this email and any attachments are
> > > > confidential and may also be privileged. If you are not the intended
> > > > recipient, please notify the sender immediately and do not disclose
> the
> > > > contents to any other person, use it for any purpose, or store or
> copy
> > > the
> > > > information in any medium. Thank you.
> > > > _______________________________________________
> > > > gem5-dev mailing list
> > > > gem5-***@gem5.org
> > > > http://m5sim.org/mailman/listinfo/gem5-dev
> > > _______________________________________________
> > > gem5-dev mailing list
> > > gem5-***@gem5.org
> > > http://m5sim.org/mailman/listinfo/gem5-dev
> > _______________________________________________
> > gem5-dev mailing list
> > gem5-***@gem5.org
> > http://m5sim.org/mailman/listinfo/gem5-dev
> _______________________________________________
> gem5-dev mailing list
> gem5-***@gem5.org
> http://m5sim.org/mailman/listinfo/gem5-dev
Loading...