Discussion:
[gem5-dev] Change in gem5/gem5[master]: base: Fix include order in the inifile unit test.
(too old to reply)
Gabe Black (Gerrit)
2018-11-29 01:47:17 UTC
Permalink
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14675


Change subject: base: Fix include order in the inifile unit test.
......................................................................

base: Fix include order in the inifile unit test.

Even though gtest.h is a C++ header, it looks like a C header which
makes the style check hook upset. Lets move it up so the hook doesn't
complain when the file is changed.

Change-Id: Ibcc2d0b7bf3b254c70e55b30379ebd4b70933c26
---
M src/base/inifiletest.cc
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/src/base/inifiletest.cc b/src/base/inifiletest.cc
index d331905..4235997 100644
--- a/src/base/inifiletest.cc
+++ b/src/base/inifiletest.cc
@@ -32,13 +32,13 @@
* Steve Reinhardt
*/

+#include <gtest/gtest.h>
+
#include <fstream>
#include <iostream>
#include <string>
#include <vector>

-#include <gtest/gtest.h>
-
#include "base/inifile.hh"

using namespace std;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14675
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibcc2d0b7bf3b254c70e55b30379ebd4b70933c26
Gerrit-Change-Number: 14675
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-MessageType: newchange
Gabe Black (Gerrit)
2018-11-29 02:51:12 UTC
Permalink
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14675 )

Change subject: base: Fix include order in the inifile unit test.
......................................................................

base: Fix include order in the inifile unit test.

Even though gtest.h is a C++ header, it looks like a C header which
makes the style check hook upset. Lets move it up so the hook doesn't
complain when the file is changed.

Change-Id: Ibcc2d0b7bf3b254c70e55b30379ebd4b70933c26
Reviewed-on: https://gem5-review.googlesource.com/c/14675
Reviewed-by: Jason Lowe-Power <***@lowepower.com>
Maintainer: Jason Lowe-Power <***@lowepower.com>
---
M src/base/inifiletest.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved



diff --git a/src/base/inifiletest.cc b/src/base/inifiletest.cc
index d331905..4235997 100644
--- a/src/base/inifiletest.cc
+++ b/src/base/inifiletest.cc
@@ -32,13 +32,13 @@
* Steve Reinhardt
*/

+#include <gtest/gtest.h>
+
#include <fstream>
#include <iostream>
#include <string>
#include <vector>

-#include <gtest/gtest.h>
-
#include "base/inifile.hh"

using namespace std;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14675
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibcc2d0b7bf3b254c70e55b30379ebd4b70933c26
Gerrit-Change-Number: 14675
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <***@google.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-MessageType: merged
Continue reading on narkive:
Loading...