Nikos Nikoleris (Gerrit)
2018-11-28 13:49:17 UTC
Hello Giacomo Travaglini,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14618
to review the following change.
Change subject: arch-arm: Add missing template declaration
......................................................................
arch-arm: Add missing template declaration
The lack of a template declaration for IllegalInstSetStateFault was
causing errors when compiling with clang.
Change-Id: If7f19d7e879330226c80df2baca73d88d818f673
Signed-off-by: Nikos Nikoleris <***@arm.com>
Reviewed-by: Giacomo Travaglini <***@arm.com>
---
M src/arch/arm/faults.hh
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/src/arch/arm/faults.hh b/src/arch/arm/faults.hh
index dcda03b..859fd34 100644
--- a/src/arch/arm/faults.hh
+++ b/src/arch/arm/faults.hh
@@ -612,6 +612,7 @@
template<> ArmFault::FaultVals ArmFaultVals<VirtualInterrupt>::vals;
template<> ArmFault::FaultVals ArmFaultVals<FastInterrupt>::vals;
template<> ArmFault::FaultVals ArmFaultVals<VirtualFastInterrupt>::vals;
+template<> ArmFault::FaultVals
ArmFaultVals<IllegalInstSetStateFault>::vals;
template<> ArmFault::FaultVals ArmFaultVals<SupervisorTrap>::vals;
template<> ArmFault::FaultVals ArmFaultVals<SecureMonitorTrap>::vals;
template<> ArmFault::FaultVals ArmFaultVals<PCAlignmentFault>::vals;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14618
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If7f19d7e879330226c80df2baca73d88d818f673
Gerrit-Change-Number: 14618
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <***@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-MessageType: newchange
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14618
to review the following change.
Change subject: arch-arm: Add missing template declaration
......................................................................
arch-arm: Add missing template declaration
The lack of a template declaration for IllegalInstSetStateFault was
causing errors when compiling with clang.
Change-Id: If7f19d7e879330226c80df2baca73d88d818f673
Signed-off-by: Nikos Nikoleris <***@arm.com>
Reviewed-by: Giacomo Travaglini <***@arm.com>
---
M src/arch/arm/faults.hh
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/src/arch/arm/faults.hh b/src/arch/arm/faults.hh
index dcda03b..859fd34 100644
--- a/src/arch/arm/faults.hh
+++ b/src/arch/arm/faults.hh
@@ -612,6 +612,7 @@
template<> ArmFault::FaultVals ArmFaultVals<VirtualInterrupt>::vals;
template<> ArmFault::FaultVals ArmFaultVals<FastInterrupt>::vals;
template<> ArmFault::FaultVals ArmFaultVals<VirtualFastInterrupt>::vals;
+template<> ArmFault::FaultVals
ArmFaultVals<IllegalInstSetStateFault>::vals;
template<> ArmFault::FaultVals ArmFaultVals<SupervisorTrap>::vals;
template<> ArmFault::FaultVals ArmFaultVals<SecureMonitorTrap>::vals;
template<> ArmFault::FaultVals ArmFaultVals<PCAlignmentFault>::vals;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14618
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If7f19d7e879330226c80df2baca73d88d818f673
Gerrit-Change-Number: 14618
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <***@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-MessageType: newchange