Discussion:
[gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
(too old to reply)
Christian Menard
2016-05-26 11:38:25 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------

Review request for Default.


Repository: gem5


Description
-------

The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.


Diffs
-----

src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d

Diff: http://reviews.gem5.org/r/3480/diff/


Testing
-------

Used in a SystemC transactor


Thanks,

Christian Menard
Jason Lowe-Power
2016-05-26 14:19:08 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/#review8352
-----------------------------------------------------------

Ship it!


Ship It!

- Jason Lowe-Power
Post by Christian Menard
-----------------------------------------------------------
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------
(Updated May 26, 2016, 11:38 a.m.)
Review request for Default.
Repository: gem5
Description
-------
The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
Diffs
-----
src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d
Diff: http://reviews.gem5.org/r/3480/diff/
Testing
-------
Used in a SystemC transactor
Thanks,
Christian Menard
Matthias Jung
2016-05-30 07:46:59 UTC
Permalink
Are the examples in /util/tlm and /util/systemc still working with this change?
What is the SystemC license? Should we consider including all/parts in ext/ so that we can always build (and test) this support?
Hi Andreas,
SystemC has its own licence, called SystemC Open Source Licence. I don't know if this fits to gem5's BSD licence ...

http://accellera.org/images/about/policies/SystemC_Open_Source_License_v3.3.pdf

Regards
Matthias


- Matthias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/#review8371
-----------------------------------------------------------
-----------------------------------------------------------
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------
(Updated Mai 26, 2016, 11:38 vorm.)
Review request for Default.
Repository: gem5
Description
-------
The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
Diffs
-----
src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d
Diff: http://reviews.gem5.org/r/3480/diff/
Testing
-------
Used in a SystemC transactor
Thanks,
Christian Menard
Andreas Hansson
2016-05-30 07:56:40 UTC
Permalink
Are the examples in /util/tlm and /util/systemc still working with this change?
What is the SystemC license? Should we consider including all/parts in ext/ so that we can always build (and test) this support?
Hi Andreas,
SystemC has its own licence, called SystemC Open Source Licence. I don't know if this fits to gem5's BSD licence ...
http://accellera.org/images/about/policies/SystemC_Open_Source_License_v3.3.pdf
Regards
Matthias
Thanks for the pointer.

Seems there are whole book-chapters on this topic(!). Not as easy as I had hoped.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/#review8371
-----------------------------------------------------------
-----------------------------------------------------------
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------
(Updated May 26, 2016, 11:38 a.m.)
Review request for Default.
Repository: gem5
Description
-------
The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
Diffs
-----
src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d
Diff: http://reviews.gem5.org/r/3480/diff/
Testing
-------
Used in a SystemC transactor
Thanks,
Christian Menard
Christian Menard
2016-05-30 14:29:24 UTC
Permalink
Are the examples in /util/tlm and /util/systemc still working with this change?
What is the SystemC license? Should we consider including all/parts in ext/ so that we can always build (and test) this support?
Hi Andreas,
SystemC has its own licence, called SystemC Open Source Licence. I don't know if this fits to gem5's BSD licence ...
http://accellera.org/images/about/policies/SystemC_Open_Source_License_v3.3.pdf
Regards
Matthias
Thanks for the pointer.
Seems there are whole book-chapters on this topic(!). Not as easy as I had hoped.
The Patch has no influence on the examples as /util/systemc does not use external ports and /util/tlm only implements an external TLM slave port. However, I'am working on a external TLM master port, so that I can connect other CPU models to gem5's memory system. I need to generate packets from TLM transactions in the external module and therefore need a MasterID.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/#review8371
-----------------------------------------------------------
-----------------------------------------------------------
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------
(Updated May 26, 2016, 11:38 a.m.)
Review request for Default.
Repository: gem5
Description
-------
The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
Diffs
-----
src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d
Diff: http://reviews.gem5.org/r/3480/diff/
Testing
-------
Used in a SystemC transactor
Thanks,
Christian Menard
Andreas Hansson
2016-05-30 05:50:53 UTC
Permalink
Post by Christian Menard
Are the examples in /util/tlm and /util/systemc still working with this change?
What is the SystemC license? Should we consider including all/parts in ext/ so that we can always build (and test) this support?


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/#review8371
-----------------------------------------------------------
Post by Christian Menard
-----------------------------------------------------------
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------
(Updated May 26, 2016, 11:38 a.m.)
Review request for Default.
Repository: gem5
Description
-------
The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
Diffs
-----
src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d
Diff: http://reviews.gem5.org/r/3480/diff/
Testing
-------
Used in a SystemC transactor
Thanks,
Christian Menard
Matthias Jung
2016-05-30 18:28:59 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/#review8383
-----------------------------------------------------------

Ship it!


Ship It!

- Matthias Jung
Post by Christian Menard
-----------------------------------------------------------
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------
(Updated Mai 26, 2016, 11:38 vorm.)
Review request for Default.
Repository: gem5
Description
-------
The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
Diffs
-----
src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d
Diff: http://reviews.gem5.org/r/3480/diff/
Testing
-------
Used in a SystemC transactor
Thanks,
Christian Menard
Christian Menard
2016-06-06 09:57:32 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------

(Updated June 6, 2016, 9:57 a.m.)


Review request for Default.


Summary (updated)
-----------------

misc: add a MasterId to the ExternalPort


Repository: gem5


Description
-------

The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.


Diffs
-----

src/mem/external_master.hh 54cf9a388a9d
src/mem/external_master.cc 54cf9a388a9d
src/mem/ExternalMaster.py 54cf9a388a9d

Diff: http://reviews.gem5.org/r/3480/diff/


Testing
-------

Used in a SystemC transactor


Thanks,

Christian Menard
Christian Menard
2016-10-26 16:06:45 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------

(Updated Oct. 26, 2016, 4:06 p.m.)


Review request for Default.


Changes
-------

updated the diff: rebased on 11691 and generated with mq


Repository: gem5


Description
-------

The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.


Diffs (updated)
-----

src/mem/ExternalMaster.py b3d5f0e9e258
src/mem/external_master.hh b3d5f0e9e258
src/mem/external_master.cc b3d5f0e9e258

Diff: http://reviews.gem5.org/r/3480/diff/


Testing
-------

Used in a SystemC transactor


Thanks,

Christian Menard
Andreas Hansson
2016-10-26 18:52:35 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/#review8987
-----------------------------------------------------------

Ship it!


Ship It!

- Andreas Hansson
Post by Christian Menard
-----------------------------------------------------------
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------
(Updated Oct. 26, 2016, 4:06 p.m.)
Review request for Default.
Repository: gem5
Description
-------
The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets.
Diffs
-----
src/mem/ExternalMaster.py b3d5f0e9e258
src/mem/external_master.hh b3d5f0e9e258
src/mem/external_master.cc b3d5f0e9e258
Diff: http://reviews.gem5.org/r/3480/diff/
Testing
-------
Used in a SystemC transactor
Thanks,
Christian Menard
Christian Menard
2017-01-09 12:19:19 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------

(Updated Jan. 9, 2017, 12:19 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
-------

Changeset 11793:3a8e34a03c9e
---------------------------
misc: add a MasterId to the ExternalPort

The Request constructor requires a MasterID. However, an external transactor
has no chance of getting a MasterID as it does not have a pointer to the
System. This patch adds a MasterID to ExternalMaster to allow external modules
to easily genrerate new Requests.


Diffs (updated)
-----

src/mem/external_master.cc c10c50cb8ac9
src/mem/ExternalMaster.py c10c50cb8ac9
src/mem/external_master.hh c10c50cb8ac9

Diff: http://reviews.gem5.org/r/3480/diff/


Testing
-------

Used in a SystemC transactor


Thanks,

Christian Menard
Christian Menard
2017-01-09 12:19:40 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3480/
-----------------------------------------------------------

(Updated Jan. 9, 2017, 12:19 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
-------

misc: add a MasterId to the ExternalPort

The Request constructor requires a MasterID. However, an external transactor
has no chance of getting a MasterID as it does not have a pointer to the
System. This patch adds a MasterID to ExternalMaster to allow external modules
to easily genrerate new Requests.


Diffs
-----

src/mem/external_master.cc c10c50cb8ac9
src/mem/ExternalMaster.py c10c50cb8ac9
src/mem/external_master.hh c10c50cb8ac9

Diff: http://reviews.gem5.org/r/3480/diff/


Testing
-------

Used in a SystemC transactor


Thanks,

Christian Menard

Loading...