Discussion:
[gem5-dev] Change in gem5/gem5[master]: base: increase the GDB buffer size
(too old to reply)
Ciro Santilli (Gerrit)
2018-11-21 18:08:52 UTC
Permalink
Ciro Santilli has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14497


Change subject: base: increase the GDB buffer size
......................................................................

base: increase the GDB buffer size

The size was not large enough for the 'G' packet on aarch64, which the
client sends to set registers.

This would lead to the stub not to be able to find the end of the input
packet and keep waiting forever.

Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
---
M src/base/remote_gdb.cc
1 file changed, 3 insertions(+), 1 deletion(-)



diff --git a/src/base/remote_gdb.cc b/src/base/remote_gdb.cc
index 37ecef9..1257d5c 100644
--- a/src/base/remote_gdb.cc
+++ b/src/base/remote_gdb.cc
@@ -152,7 +152,9 @@
static const char GDBGoodP = '+';
static const char GDBBadP = '-';

-static const int GDBPacketBufLen = 1024;
+// This value was found by trial and error to be enough for
+// all tested packets.
+static const int GDBPacketBufLen = 16384;

vector<BaseRemoteGDB *> debuggers;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14497
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 1
Gerrit-Owner: Ciro Santilli <***@arm.com>
Gerrit-MessageType: newchange
Ciro Santilli (Gerrit)
2018-11-27 13:42:41 UTC
Permalink
Hello Gabe Black, Jason Lowe-Power, Giacomo Travaglini, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/14497

to look at the new patch set (#2).

Change subject: base: increase the GDB buffer size dynamically
......................................................................

base: increase the GDB buffer size dynamically

The size was not large enough for the 'G' packet on aarch64, which the
client sends to set registers.

This would lead to the stub not to be able to find the end of the input
packet and keep waiting forever.

Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
---
M src/base/remote_gdb.cc
M src/base/remote_gdb.hh
2 files changed, 18 insertions(+), 33 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14497
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 2
Gerrit-Owner: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-MessageType: newpatchset
Ciro Santilli (Gerrit)
2018-11-28 16:20:01 UTC
Permalink
Hello Gabe Black, Jason Lowe-Power, Giacomo Travaglini, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/14497

to look at the new patch set (#3).

Change subject: base: increase the GDB buffer size dynamically
......................................................................

base: increase the GDB buffer size dynamically

The size was not large enough for the 'G' packet on aarch64, which the
client sends to set registers.

This would lead to the stub not to be able to find the end of the input
packet and keep waiting forever.

Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
---
M src/base/remote_gdb.cc
M src/base/remote_gdb.hh
2 files changed, 17 insertions(+), 33 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14497
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 3
Gerrit-Owner: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-MessageType: newpatchset
Ciro Santilli (Gerrit)
2018-11-28 16:21:23 UTC
Permalink
Hello Gabe Black, Jason Lowe-Power, Giacomo Travaglini, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/14497

to look at the new patch set (#4).

Change subject: base: increase the GDB buffer size dynamically
......................................................................

base: increase the GDB buffer size dynamically

The size was not large enough for the 'G' packet on aarch64, which the
client sends to set registers.

This would lead to the stub not to be able to find the end of the input
packet and keep waiting forever.

Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
---
M src/base/remote_gdb.cc
M src/base/remote_gdb.hh
2 files changed, 18 insertions(+), 33 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14497
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 4
Gerrit-Owner: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-MessageType: newpatchset
Ciro Santilli (Gerrit)
2018-11-29 12:35:07 UTC
Permalink
Hello Gabe Black, Jason Lowe-Power, Giacomo Travaglini, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/14497

to look at the new patch set (#5).

Change subject: base: increase the GDB buffer size dynamically
......................................................................

base: increase the GDB buffer size dynamically

The size was not large enough for the 'G' packet on aarch64, which the
client sends to set registers.

This would lead to the stub not to be able to find the end of the input
packet and keep waiting forever.

Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
---
M src/base/remote_gdb.cc
M src/base/remote_gdb.hh
2 files changed, 18 insertions(+), 34 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14497
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Icb149f15a6c769371ebcb6ec5fbebc6170c31fc6
Gerrit-Change-Number: 14497
Gerrit-PatchSet: 5
Gerrit-Owner: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Andreas Sandberg <***@arm.com>
Gerrit-Reviewer: Ciro Santilli <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-MessageType: newpatchset
Continue reading on narkive:
Loading...