Discussion:
[gem5-dev] Review Request: mem: Add tracing support in the communication monitor
(too old to reply)
Andreas Hansson
2012-12-07 04:20:31 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1574/
-----------------------------------------------------------

Review request for Default.


Description
-------

Changeset 9369:64fdde7bd4a2
---------------------------
mem: Add tracing support in the communication monitor

This patch adds packet tracing to the communication monitor using a
protobuf as the mechanism for creating the trace.

If no file is specified, then the tracing is disabled. If a file is
specified, then for every packet that is successfully sent, a protobuf
message is serialized to the file.


Diffs
-----

src/base/output.hh 844f9e724343
src/base/output.cc 844f9e724343
src/mem/CommMonitor.py 844f9e724343
src/mem/comm_monitor.hh 844f9e724343
src/mem/comm_monitor.cc 844f9e724343
src/proto/SConscript PRE-CREATION
src/proto/packet.proto PRE-CREATION
tests/configs/tgen-simple-mem.py 844f9e724343

Diff: http://reviews.gem5.org/r/1574/diff/


Testing
-------

util/regress all passing (disregarding t1000 and eio)


Thanks,

Andreas Hansson
Ali Saidi
2012-12-07 21:40:38 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1574/#review3729
-----------------------------------------------------------

Ship it!


Ship It!

- Ali Saidi
Post by Andreas Hansson
-----------------------------------------------------------
http://reviews.gem5.org/r/1574/
-----------------------------------------------------------
(Updated Dec. 6, 2012, 8:20 p.m.)
Review request for Default.
Description
-------
Changeset 9369:64fdde7bd4a2
---------------------------
mem: Add tracing support in the communication monitor
This patch adds packet tracing to the communication monitor using a
protobuf as the mechanism for creating the trace.
If no file is specified, then the tracing is disabled. If a file is
specified, then for every packet that is successfully sent, a protobuf
message is serialized to the file.
Diffs
-----
src/base/output.hh 844f9e724343
src/base/output.cc 844f9e724343
src/mem/CommMonitor.py 844f9e724343
src/mem/comm_monitor.hh 844f9e724343
src/mem/comm_monitor.cc 844f9e724343
src/proto/SConscript PRE-CREATION
src/proto/packet.proto PRE-CREATION
tests/configs/tgen-simple-mem.py 844f9e724343
Diff: http://reviews.gem5.org/r/1574/diff/
Testing
-------
util/regress all passing (disregarding t1000 and eio)
Thanks,
Andreas Hansson
Andreas Hansson
2012-12-12 14:51:46 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1574/
-----------------------------------------------------------

(Updated Dec. 12, 2012, 6:51 a.m.)


Review request for Default.


Description (updated)
-------

Changeset 9369:aa9d2425a301
---------------------------
mem: Add tracing support in the communication monitor

This patch adds packet tracing to the communication monitor using a
protobuf as the mechanism for creating the trace.

If no file is specified, then the tracing is disabled. If a file is
specified, then for every packet that is successfully sent, a protobuf
message is serialized to the file.


Diffs (updated)
-----

src/base/output.hh 844f9e724343
src/base/output.cc 844f9e724343
src/mem/CommMonitor.py 844f9e724343
src/mem/SConscript 844f9e724343
src/mem/comm_monitor.hh 844f9e724343
src/mem/comm_monitor.cc 844f9e724343
src/proto/SConscript PRE-CREATION
src/proto/packet.proto PRE-CREATION
tests/configs/tgen-simple-mem.py 844f9e724343

Diff: http://reviews.gem5.org/r/1574/diff/


Testing
-------

util/regress all passing (disregarding t1000 and eio)


Thanks,

Andreas Hansson
Nilay Vaish
2013-01-03 15:48:29 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1574/#review3771
-----------------------------------------------------------



src/proto/SConscript
<http://reviews.gem5.org/r/1574/#comment3683>

Shouldn't this directory be in the src/mem directory?


- Nilay Vaish
Post by Andreas Hansson
-----------------------------------------------------------
http://reviews.gem5.org/r/1574/
-----------------------------------------------------------
(Updated Dec. 12, 2012, 6:51 a.m.)
Review request for Default.
Description
-------
Changeset 9369:aa9d2425a301
---------------------------
mem: Add tracing support in the communication monitor
This patch adds packet tracing to the communication monitor using a
protobuf as the mechanism for creating the trace.
If no file is specified, then the tracing is disabled. If a file is
specified, then for every packet that is successfully sent, a protobuf
message is serialized to the file.
Diffs
-----
src/base/output.hh 844f9e724343
src/base/output.cc 844f9e724343
src/mem/CommMonitor.py 844f9e724343
src/mem/SConscript 844f9e724343
src/mem/comm_monitor.hh 844f9e724343
src/mem/comm_monitor.cc 844f9e724343
src/proto/SConscript PRE-CREATION
src/proto/packet.proto PRE-CREATION
tests/configs/tgen-simple-mem.py 844f9e724343
Diff: http://reviews.gem5.org/r/1574/diff/
Testing
-------
util/regress all passing (disregarding t1000 and eio)
Thanks,
Andreas Hansson
Andreas Hansson
2013-01-03 15:51:41 UTC
Permalink
Post by Andreas Hansson
src/proto/SConscript, line 42
<http://reviews.gem5.org/r/1574/diff/2/?file=32822#file32822line42>
Shouldn't this directory be in the src/mem directory?
I would say no as we will also be using the proto support for CPU instruction tracing amongst other things. We could even envision using protobuf for the checkpoints in the future :-)

The only bit that would be suitable for the mem directory would be the packet.proto, but I would prefer to keep that in the same place as the rest. Sensible enough?


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1574/#review3771
-----------------------------------------------------------
Post by Andreas Hansson
-----------------------------------------------------------
http://reviews.gem5.org/r/1574/
-----------------------------------------------------------
(Updated Dec. 12, 2012, 6:51 a.m.)
Review request for Default.
Description
-------
Changeset 9369:aa9d2425a301
---------------------------
mem: Add tracing support in the communication monitor
This patch adds packet tracing to the communication monitor using a
protobuf as the mechanism for creating the trace.
If no file is specified, then the tracing is disabled. If a file is
specified, then for every packet that is successfully sent, a protobuf
message is serialized to the file.
Diffs
-----
src/base/output.hh 844f9e724343
src/base/output.cc 844f9e724343
src/mem/CommMonitor.py 844f9e724343
src/mem/SConscript 844f9e724343
src/mem/comm_monitor.hh 844f9e724343
src/mem/comm_monitor.cc 844f9e724343
src/proto/SConscript PRE-CREATION
src/proto/packet.proto PRE-CREATION
tests/configs/tgen-simple-mem.py 844f9e724343
Diff: http://reviews.gem5.org/r/1574/diff/
Testing
-------
util/regress all passing (disregarding t1000 and eio)
Thanks,
Andreas Hansson
Nilay Vaish
2013-01-05 15:58:01 UTC
Permalink
Post by Andreas Hansson
src/proto/SConscript, line 42
<http://reviews.gem5.org/r/1574/diff/2/?file=32822#file32822line42>
Shouldn't this directory be in the src/mem directory?
I would say no as we will also be using the proto support for CPU instruction tracing amongst other things. We could even envision using protobuf for the checkpoints in the future :-)
The only bit that would be suitable for the mem directory would be the packet.proto, but I would prefer to keep that in the same place as the rest. Sensible enough?
Yes.


- Nilay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1574/#review3771
-----------------------------------------------------------
Post by Andreas Hansson
-----------------------------------------------------------
http://reviews.gem5.org/r/1574/
-----------------------------------------------------------
(Updated Dec. 12, 2012, 6:51 a.m.)
Review request for Default.
Description
-------
Changeset 9369:aa9d2425a301
---------------------------
mem: Add tracing support in the communication monitor
This patch adds packet tracing to the communication monitor using a
protobuf as the mechanism for creating the trace.
If no file is specified, then the tracing is disabled. If a file is
specified, then for every packet that is successfully sent, a protobuf
message is serialized to the file.
Diffs
-----
src/base/output.hh 844f9e724343
src/base/output.cc 844f9e724343
src/mem/CommMonitor.py 844f9e724343
src/mem/SConscript 844f9e724343
src/mem/comm_monitor.hh 844f9e724343
src/mem/comm_monitor.cc 844f9e724343
src/proto/SConscript PRE-CREATION
src/proto/packet.proto PRE-CREATION
tests/configs/tgen-simple-mem.py 844f9e724343
Diff: http://reviews.gem5.org/r/1574/diff/
Testing
-------
util/regress all passing (disregarding t1000 and eio)
Thanks,
Andreas Hansson
Nilay Vaish
2013-01-05 15:58:28 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1574/#review3782
-----------------------------------------------------------

Ship it!


Ship It!

- Nilay Vaish
Post by Andreas Hansson
-----------------------------------------------------------
http://reviews.gem5.org/r/1574/
-----------------------------------------------------------
(Updated Dec. 12, 2012, 6:51 a.m.)
Review request for Default.
Description
-------
Changeset 9369:aa9d2425a301
---------------------------
mem: Add tracing support in the communication monitor
This patch adds packet tracing to the communication monitor using a
protobuf as the mechanism for creating the trace.
If no file is specified, then the tracing is disabled. If a file is
specified, then for every packet that is successfully sent, a protobuf
message is serialized to the file.
Diffs
-----
src/base/output.hh 844f9e724343
src/base/output.cc 844f9e724343
src/mem/CommMonitor.py 844f9e724343
src/mem/SConscript 844f9e724343
src/mem/comm_monitor.hh 844f9e724343
src/mem/comm_monitor.cc 844f9e724343
src/proto/SConscript PRE-CREATION
src/proto/packet.proto PRE-CREATION
tests/configs/tgen-simple-mem.py 844f9e724343
Diff: http://reviews.gem5.org/r/1574/diff/
Testing
-------
util/regress all passing (disregarding t1000 and eio)
Thanks,
Andreas Hansson
Continue reading on narkive:
Loading...