Discussion:
[gem5-dev] Change in gem5/gem5[master]: base: Add missing overrides in statistics header
(too old to reply)
Nikos Nikoleris (Gerrit)
2018-11-28 13:49:17 UTC
Permalink
Hello Giacomo Travaglini,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/14619

to review the following change.


Change subject: base: Add missing overrides in statistics header
......................................................................

base: Add missing overrides in statistics header

Change-Id: Id5ee2a970a3dceee1b7e24ce3b452b7fece87875
Signed-off-by: Nikos Nikoleris <***@arm.com>
Reviewed-by: Giacomo Travaglini <***@arm.com>
---
M src/base/statistics.hh
1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/src/base/statistics.hh b/src/base/statistics.hh
index 3e1758a..404bdf1 100644
--- a/src/base/statistics.hh
+++ b/src/base/statistics.hh
@@ -2320,7 +2320,7 @@
BinaryNode(NodePtr &a, NodePtr &b) : l(a), r(b) {}

const VResult &
- result() const
+ result() const override
{
Op op;
const VResult &lvec = l->result();
@@ -2352,7 +2352,7 @@
}

Result
- total() const
+ total() const override
{
const VResult &vec = this->result();
const VResult &lvec = l->result();
@@ -2384,7 +2384,7 @@
}

size_type
- size() const
+ size() const override
{
size_type ls = l->size();
size_type rs = r->size();
@@ -2399,7 +2399,7 @@
}

std::string
- str() const
+ str() const override
{
return csprintf("(%s %s %s)", l->str(), OpString<Op>::str(),
r->str());
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14619
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id5ee2a970a3dceee1b7e24ce3b452b7fece87875
Gerrit-Change-Number: 14619
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <***@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-MessageType: newchange
Nikos Nikoleris (Gerrit)
2018-11-28 18:20:41 UTC
Permalink
Nikos Nikoleris has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14619 )

Change subject: base: Add missing overrides in statistics header
......................................................................

base: Add missing overrides in statistics header

Change-Id: Id5ee2a970a3dceee1b7e24ce3b452b7fece87875
Signed-off-by: Nikos Nikoleris <***@arm.com>
Reviewed-by: Giacomo Travaglini <***@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/14619
Reviewed-by: Jason Lowe-Power <***@lowepower.com>
Maintainer: Jason Lowe-Power <***@lowepower.com>
---
M src/base/statistics.hh
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved



diff --git a/src/base/statistics.hh b/src/base/statistics.hh
index 3e1758a..404bdf1 100644
--- a/src/base/statistics.hh
+++ b/src/base/statistics.hh
@@ -2320,7 +2320,7 @@
BinaryNode(NodePtr &a, NodePtr &b) : l(a), r(b) {}

const VResult &
- result() const
+ result() const override
{
Op op;
const VResult &lvec = l->result();
@@ -2352,7 +2352,7 @@
}

Result
- total() const
+ total() const override
{
const VResult &vec = this->result();
const VResult &lvec = l->result();
@@ -2384,7 +2384,7 @@
}

size_type
- size() const
+ size() const override
{
size_type ls = l->size();
size_type rs = r->size();
@@ -2399,7 +2399,7 @@
}

std::string
- str() const
+ str() const override
{
return csprintf("(%s %s %s)", l->str(), OpString<Op>::str(),
r->str());
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14619
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id5ee2a970a3dceee1b7e24ce3b452b7fece87875
Gerrit-Change-Number: 14619
Gerrit-PatchSet: 2
Gerrit-Owner: Nikos Nikoleris <***@arm.com>
Gerrit-Reviewer: Gabe Black <***@google.com>
Gerrit-Reviewer: Giacomo Travaglini <***@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <***@lowepower.com>
Gerrit-Reviewer: Nikos Nikoleris <***@arm.com>
Gerrit-MessageType: merged
Continue reading on narkive:
Loading...